BUG: avoid segmentation fault in string_expandtabs_length_promoter
#29368
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the first item in numpy#28829. `op_dtypes[0]` may be null, so use `op_dtypes[1]` instead.
riku-sakamoto
force-pushed
the
fix_expandtabs_length_segfault
branch
from
13d91c7 to
1aae38f
Compare
|
ping @lysnikolaou |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first item in #28829.
op_dtypes[0]may be null, so useop_dtypes[1]instead.This is my first PR to NumPy, so please let me know if there's anything I should fix or improve.
Root Cause
string_expandtabs_length_promoter, the first item ofop_dtypescan be NULL.Rationale
ops, legacy type resolution does not handle NULL well. Therefore, I changed the logic to use the second item instead.Outcome
numpy._core.strings._expandtabs_length.reduce(numpy.zeros(200))now raises aUFuncTypeError, instead of causing a segmentation fault.