ENH: array comparison utils show calculations and indices of max errors #29395
+281
−146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not needed since e6b68e5
Noticed the extra dimension while adding the index of the max error to assert_array_XXX_nulp output
Noticed these while attempting to append more content to the expected message, upon which the partial values started causing the regex to stop matching.
Resolves numpy#28827 - Verbose assertion errors raised by testing.assert_allclose and testing.assert_array_XXX now show the calculation and the indices of the maximum absolute and relative differences among the violations. - Assertion errors raised by assert_array_almost_equal_nulp and assert_array_max_ulp, which have no verbose toggle, now show the indices of the maximum ULP difference. The main complexity adding this feature was that one could not 'simply' replace `max` with `argmax` due to masking: the absolute differences is calculated after masking out infs and nans, and the relative differences are additionally calculated after masking out zero denominators.
danra
force-pushed
the
max_errors_indices
branch
from
58a5820 to
a967767
Compare
|
Is the failing test maybe an instance of #29262 ? |
|
It looks like pypy segfaulted on your PR. I don't think it's the same issue you linked to. Definitely a real problem but probably unrelated to this PR and safe for you to ignore. Unfortunately the NumPy CI is sufficiently complicated that along with several heisenbugs bits and pieces regularly start failing for lots of reasons. Unless you're interested in helping out with a fix, it's usually safe to ignore. If you're unsure, just ask, and a maintainer should catch it if an error is real and it was ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28827
testing.assert_allcloseandtesting.assert_array_XXXnow show the calculation and the indices of the maximum absolute and relative differences among the violations.assert_array_almost_equal_nulpandassert_array_max_ulp, which have no verbose toggle, now show the indices of the maximum ULP difference.The main complexity adding this feature was that one could not 'simply' replace
maxwithargmaxdue to masking: the absolute differences is calculated after masking out infs and nans, and the relative differences are additionally calculated after masking out zero denominators.Notes to reviewer: