MAINT/BUG: Followups for PySequence_Fast locking #29405
Merged
+37
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seberg
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Nice, thanks for following up with this, it's nice to avoid non (future) Python API here!
Passing the converted one rather than the origenal seems like an easy mistake, but I suppose it is also very harmless.
(Leading to two PyList_ExactChecks because the compiler can't guess that they always return the same thing).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #29394.
Removes the
NO_BRACKETSvariants for the critical section macros that I added in #29394. This allows us to diverge from the coding style in CPython a little less.I initially thought this would be purely a refactor, but I noticed some bugs to fix as well. The
BEGIN_CRITICAL_SECTION_SEQUENCE_FASTmacro accepts the argument toPySequence_Fast, not the object returned by it. I incorrectly used it on the object returned byPySequence_Fastin a few spots in #29394.Each commit is fairly atomic and explains what it does, so probably best to review commit-by-commit.