Content-Length: 253823 | pFad | http://github.com/nushell/reedline/pull/881

D5 Moved partial completion menu next into new menu event by uek-1 · Pull Request #881 · nushell/reedline · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved partial completion menu next into new menu event #881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Moved partial completion menu next into new menu event #881

wants to merge 1 commit into from

Conversation

uek-1
Copy link
Contributor

@uek-1 uek-1 commented Feb 8, 2025 •
edited
Loading

Addresses nushell/nushell#14152 (more context can also be found in #828 ). Creates a separate event, MenuNextComplete, that not only selects the next element but also attempts to partially complete the selection. Reverts MenuNext to simply advancing the next element and quick completing if possible.

The nushell PR to use this new event can be found at nushell/nushell#15063

@uek-1 uek-1 mentioned this pull request Feb 8, 2025
Draft
@132ikl
Copy link

132ikl commented Feb 14, 2025

is there a use case for sending MenuNext without completing? not sure if we should have a new event for this, or just change the behavior of MenuNext. but i'm not super familiar with the completion stuff. (cc @blindFS, @ysthakur)

@blindFS
Copy link
Contributor

blindFS commented Feb 14, 2025 •
edited
Loading

@132ikl I'd like this because when the only valid options are say foo and foooo, a typical bash behavior of f#tab would complete the repl text to foo without moving the menu item towards foooo

Sorry I didn't check the code, it seems different from what I thought.
@uek-1 I was thinking about a new event with only the partial match blabla side effects (which will cause the repl text to change?), and no next item move. And we can set tab to be any of those events handled first, so the foo example will behave as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uek-1 @132ikl @blindFS








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/nushell/reedline/pull/881

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy