feat: add support for x-omitzero #1944
Open
+88
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzap
commented
Apr 17, 2025
jamietanna
reviewed
May 9, 2025
| x-omitempty: true | ||
| x-omitzero: true |
There was a problem hiding this comment.
Do both of these need to be set, here? Or should we only have x-omitzero?
There was a problem hiding this comment.
Sure, probably a leftover. Rebased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
I do not want to add this by default, not sure what consequences would be, but I want to be able to start playing around with it.
I can do add documentation as well to the README if you like it.