Fixed linter issue, renamed unittest folder to avoid name conflict #901
Conversation
cristiprg
force-pushed
the
conflicting-unittest-folder-name
branch
from
849d269 to
7146670
Compare
|
Thanks for running Github worflows @auvipy! I've fixed the other two linting issues. And also checked |
There was a problem hiding this comment.
readme: commands[0]> twine check '.tox/.pkg/dist/'
Checking .tox/.pkg/dist/oauthlib-3.2.2.tar.gz: FAILED
ERROR long_description has syntax errors in markup and would not be
rendered on PyPI.
line 79: Warning: Bullet list ends without a blank line; unexpected
unindent.
readme: exit 1 (0.38 seconds) /home/runner/work/oauthlib/oauthlib> twine check '.tox/.pkg/dist/' pid=2947
I tried reproducing that error on my local and it passes. I tried with different python versions 🤔 |
|
ooh it might the last commit, merged yesterday 2e203f1 |
Since there is no real reason for this folder to be called "unittest", I renamed it to "unittests". As a bonus, it's also consistent with the folder name "tests", both in the plural form.
Fixed the following two issues: 1. Error: oauthlib/oauth2/rfc6749/endpoints/resource.py:84:35: PLC1802 `len(estimates)` used as condition without comparison 2. Error: tests/oauth2/rfc6749/grant_types/test_refresh_token.py:187:47: SIM905 Consider using a list literal instead of `str.split`
cristiprg
force-pushed
the
conflicting-unittest-folder-name
branch
from
7146670 to
09c1f7b
Compare
|
@auvipy I've rebased on latest master and fixed the indentation issue that slipped in that commit. If I run locally |
|
we have another merge conflict to fix. may be it would be better to revisit after v3.3.0 release |
Co-authored-by: Christian Clauss <cclauss@me.com>
Since there is no real reason for this folder to be called "unittest", I renamed it to "unittests". As a bonus, it's also consistent with the folder name "tests", both in the plural form.
https://github.com/oauthlib/oauthlib/actions/runs/13734876394/job/38417326164#step:6:19