[FIX] account: do not affect base of tax without "is_base_affected" #193451
+55
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kitan191
force-pushed
the
saas-17.2-opw-4450494-fix_base_affected_by_previous_tax-pta
branch
3 times, most recently
from
73a55c4 to
813ebba
Compare
kitan191
changed the title
Steps to reproduce: - Install Accounting - Create a first tax: * Tax Name: Tax1 * Tax Computation: Percentage of Price * Tax Type: Sales * Amount: 20% * Label on Invoices: Tax1 * Tax Group: Tax1 * Affect Base of Subsequent Taxes: [Checked] - Create a second tax: * Tax Name: Tax2 * Tax Computation: Percentage of Price * Tax Type: Sales * Amount: 20% * Label on Invoices: Tax2 * Tax Group: Tax2 * Base Affected by Previous Taxes: [Not checked] - Create an invoice - Add an invoice line - Add Tax1 - Add Tax2 Issue: Base amount of Tax2 is affected by Tax1 when it should not. opw-4450494
kitan191
force-pushed
the
saas-17.2-opw-4450494-fix_base_affected_by_previous_tax-pta
branch
from
813ebba to
594b7b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue:
Base amount of Tax2 is affected by Tax1 when it should not.
opw-4450494
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr