[FIX] pos_online_payment: access error if no customer when paying online #193881
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @caburj @thvi-odoo Can you have a look please ? Thank you |
C3POdoo
requested review from
a team and
caburj
and removed request for
a team
caburj
reviewed
Jan 16, 2025
| @@ -96,7 +96,7 @@ def pos_order_pay(self, pos_order_id, access_token=None, exit_route=None): | |||
|
|
|||
| user_sudo = request.env.user | |||
| if not pos_order_sudo.partner_id: | |||
| user_sudo = request.env.ref('base.public_user') | |||
| user_sudo = request.env.ref('base.public_user').sudo() | |||
There was a problem hiding this comment.
maybe we need to use _get_public_user from res.company to get the proper public user.
There was a problem hiding this comment.
Oh nice, but that method is in website module, therefore i move it into base module
Please review
* STEP TO REPRODUCE: Have 2 company (1 is Default San Francisco the
other is VN company),Start enviroment in VN company -> config an online
payment method with
Demo/Wire
Transfer -> Start session and create pos order with no customer then
Validate -> Customer scan QR code using mobile (not logged in) -> 403
forbidden error, read the log said: Sorry, Public user for VN company
(id=10) doesn't have 'read' access to:
- User (res.users)
* REASON: when request.env.ref('base.public_user') it will get public
user from San Francisco company while the requested user is Public User
of
VN company, the record rule prevent that
* SOLUTION: Fix by using method _get_public_user() in res.company, this
commit also move _get_public_user() from website to base module so other
modules can use it
ndd-odoo
force-pushed
the
v17_fix_pos_online_payment
branch
from
efd31de to
d9b0c48
Compare
C3POdoo
requested review from
a team,
Gorash and
xmo-odoo
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo/Wire
Transfer -> Start session and create pos order with no customer then Validate -> Customer scan QR code using mobile (not logged in) -> 403 forbidden error, read the log said: Sorry, Public user for VN company (id=10) doesn't have 'read' access to: User (res.users)
commit also move _get_public_user() from website to base module so other
modules can use it
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr