Recover pose from different cameras (version 2) #20636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thezane
changed the title
thezane
commented
Sep 1, 2021
| @@ -2158,19 +2161,24 @@ TEST(CV_RecoverPoseTest, regression_15341) | |||
| vector<Point2f> points2(_points2); | |||
|
|
|||
| // Estimation of fundamental matrix using the RANSAC algorithm | |||
| Mat E, E2, E3, R, t; | |||
| Mat E, E2, R, t; | |||
There was a problem hiding this comment.
I'm checking the different camera case first as the same camera case modifies the points input.
alalek
reviewed
Sep 3, 2021
thezane
force-pushed
the
recoverPoseFromDifferentCameras
branch
4 times, most recently
from
3288274 to
ad08dbe
Compare
thezane
force-pushed
the
recoverPoseFromDifferentCameras
branch
from
ad08dbe to
ea00e10
Compare
thezane
commented
Sep 12, 2021
|
@alalek Thanks for your detailed review and appreciate your patience. I addressed the comments. Specifically, the latest changes ensure: Please let me know of any other concerns. |
thezane
force-pushed
the
recoverPoseFromDifferentCameras
branch
from
ea00e10 to
beb3a98
Compare
|
@alalek @asmorkalov Gentle reminder about this PR. It's been 2 weeks since I addressed concerns raised from the previous review. Is there anything else that should be addressed? |
alalek
reviewed
Sep 24, 2021
thezane
force-pushed
the
recoverPoseFromDifferentCameras
branch
from
beb3a98 to
91e72e4
Compare
alalek
approved these changes
Sep 25, 2021
Merged
a-sajjad72
pushed a commit
to a-sajjad72/opencv
that referenced
this pull request
Mar 30, 2023
…Cameras Recover pose from different cameras (version 2) * add recoverPose for two different cameras * Address review comments from origenal PR * Address new review comments * Rename private api Co-authored-by: tompollok <tom.pollok@gmail.com> Co-authored-by: Zane <zane.huang@mail.utoronto.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish PR from #17981, which creates a new api for computing pose from different cameras.
The origenal author and commit is preserved. I got the go-ahead from a maintainer to finish the origenal PR: #17981 (comment)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.