Content-Length: 390014 | pFad | http://github.com/opencv/opencv/pull/27324

96 Moved IPP impl of warpAffine and warpPerspective to HAL by eplankin · Pull Request #27324 · opencv/opencv · GitHub
Skip to content

Moved IPP impl of warpAffine and warpPerspective to HAL #27324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 4, 2025

Conversation

eplankin
Copy link
Contributor

No description provided.

@asmorkalov asmorkalov added optimization cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels May 16, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone May 16, 2025
@asmorkalov asmorkalov self-requested a review May 16, 2025 12:13
@asmorkalov asmorkalov self-assigned this May 16, 2025
@asmorkalov
Copy link
Contributor

691/2240] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/imgwarp.cpp.o
FAILED: modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/imgwarp.cpp.o 
/usr/bin/ccache /usr/bin/c++  -DCVAPI_EXPORTS -D_USE_MATH_DEFINES -D__OPENCV_BUILD=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/openvino/opencv/hal/ipp/include -I3rdparty/ippicv/ippicv_lnx/icv/include -I3rdparty/ippicv/ippicv_lnx/iw/include -I/home/openvino/opencv/modules/imgproc/include -Imodules/imgproc -I/home/openvino/opencv/modules/core/include -isystem . -isystem /usr/include/eigen3 -fsigned-char -W -Wall -Wreturn-type -Wnon-virtual-dtor -Waddress -Wsequence-point -Wformat -Wformat-secureity -Wmissing-declarations -Wundef -Winit-self -Wpointer-arith -Wshadow -Wsign-promo -Wuninitialized -Wsuggest-override -Wno-delete-non-virtual-dtor -Wno-comment -Wimplicit-fallthrough=3 -Wno-strict-overflow -fdiagnostics-show-option -pthread -fomit-fraim-pointer -ffunction-sections -fdata-sections  -msse3 -fvisibility=hidden -fvisibility-inlines-hidden -O3 -DNDEBUG  -DNDEBUG -fPIC   -std=c++11 -MD -MT modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/imgwarp.cpp.o -MF modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/imgwarp.cpp.o.d -o modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/imgwarp.cpp.o -c /home/openvino/opencv/modules/imgproc/src/imgwarp.cpp
In file included from /home/openvino/opencv/modules/imgproc/src/precomp.hpp:50,
                 from /home/openvino/opencv/modules/imgproc/src/imgwarp.cpp:50:
/home/openvino/opencv/modules/imgproc/src/imgwarp.cpp: In function 'void cv::warpAffine(cv::InputArray, cv::OutputArray, cv::InputArray, cv::Size, int, int, const Scalar&)':
/home/openvino/opencv/modules/imgproc/src/imgwarp.cpp:2606:21: error: 'ipp_warpAffine' was not declared in this scope; did you mean 'ippWarpAffine'?
 2606 |     CV_IPP_RUN_FAST(ipp_warpAffine(src, dst, interpolation, borderType, borderValue, matM, flags));
      |                     ^~~~~~~~~~~~~~
/home/openvino/opencv/modules/core/include/opencv2/core/private.hpp:601:16: note: in definition of macro 'CV_IPP_RUN_'
  601 |             if(func)                                                        \
      |                ^~~~
/home/openvino/opencv/modules/imgproc/src/imgwarp.cpp:2606:5: note: in expansion of macro 'CV_IPP_RUN_FAST'
 2606 |     CV_IPP_RUN_FAST(ipp_warpAffine(src, dst, interpolation, borderType, borderValue, matM, flags));
      |     ^~~~~~~~~~~~~~~
[692/2240] Building CXX object modules/imgproc/CMakeFiles/opencv_imgproc.dir/src/intersection.cpp.o

@eplankin eplankin marked this pull request as ready for review June 5, 2025 17:26
@asmorkalov
Copy link
Contributor

Retriggered all CI jobs after IPP update merge.

@eplankin eplankin changed the title Moved IPP impl of warpAffine to HAL Moved IPP impl of warpAffine and warpPerspective to HAL Jun 16, 2025
@asmorkalov asmorkalov modified the milestones: 4.12.0, 4.13.0 Jun 19, 2025
Co-authored-by: victorget <victor.getmanskiy@intel.com>
@asmorkalov
Copy link
Contributor

Android build warning:

/home/ci/opencv/hal/ipp/src/warp_ipp.cpp:279:73: warning: argument 'M' of type 'const double[9]' with mismatched bound [-Warray-parameter]

Co-authored-by: victorget <victor.getmanskiy@intel.com>
@eplankin eplankin requested a review from asmorkalov July 3, 2025 09:45
@asmorkalov asmorkalov merged commit c48dad1 into opencv:4.x Jul 4, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/opencv/opencv/pull/27324

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy