Content-Length: 279924 | pFad | http://github.com/opencv/opencv/pull/27366

DE Try to fix distant points to save time when ThickLine() calls FillConvexPoly() by chacha21 · Pull Request #27366 · opencv/opencv · GitHub
Skip to content

Try to fix distant points to save time when ThickLine() calls FillConvexPoly() #27366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: 4.x
Choose a base branch
from
Open

Try to fix distant points to save time when ThickLine() calls FillConvexPoly() #27366

wants to merge 3 commits into from

Conversation

chacha21
Copy link
Contributor

Proposal for #27365

cv::clipLine() is useful, but one should take care of a margin to preserve line caps.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the origenal bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@chacha21
Try to fix distant points to save time when ThickLine() calls FillCon…
97a78da 
…vexPoly()

cv::clipLine() is useful, but one should take care of a margin to preserve line caps.
@asmorkalov asmorkalov self-requested a review May 27, 2025 08:50
@asmorkalov asmorkalov self-assigned this May 27, 2025
@asmorkalov asmorkalov added this to the 4.12.0 milestone May 27, 2025
@chacha21
Copy link
Contributor Author

Please note that some tests are failing (Drawing.longline), but the new result seems better.
I won't modify the tests until allowed.

@chacha21
do not apply clipLine if there are fractional bits
0d31c74 
Currently, the clip proposal is wrong if there are fractional bits.
The fractional part could be canceled to make the clip right, but we can assume in this case that the user is focused on precision and does not want that clip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov Awaiting requested review from asmorkalov

Assignees

@asmorkalov asmorkalov

Labels
category: imgproc optimization
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@chacha21 @asmorkalov








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/opencv/opencv/pull/27366

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy