Fix incorrect Y-coordinate sampling in drawing primitives (circle, text, ellipse) #27422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmorkalov
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a logical error in the
samples/python/drawing.pyscript where both X and Y coordinates for drawing primitives (cv.circle,cv.putText,cv.ellipse) were being sampled from the X-axis range(x1, x2). This led to improper distribution and alignment of elements along the Y-axis.Changes Made
centerandorglists to use(y1, y2)instead of mistakenly reusing(x1, x2).circles()string()ellipse()Impact
This ensures that all shapes and text are now placed randomly and correctly across the entire canvas using the proper X and Y ranges.
Let me know if you'd like help opening a corresponding issue or testing these changes further.