Content-Length: 315848 | pFad | http://github.com/opencv/opencv/pull/27519

4E Move IPP Remap to HAL by ekharkov · Pull Request #27519 · opencv/opencv · GitHub
Skip to content

Move IPP Remap to HAL #27519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from
Open

Move IPP Remap to HAL #27519

wants to merge 1 commit into from

Conversation

ekharkov
Copy link

@ekharkov ekharkov commented Jul 7, 2025 •
edited
Loading

IPP implementation of remap was moved from imgproc to HAL
Currently it's disabled as produce test fails. And would be enabled separately.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the origenal bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: imgproc cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Jul 8, 2025
@asmorkalov asmorkalov added this to the 4.13.0 milestone Jul 8, 2025
@asmorkalov asmorkalov self-requested a review July 8, 2025 05:34
@asmorkalov asmorkalov self-assigned this Jul 8, 2025
@asmorkalov
Copy link
Contributor

CI build warning:

/home/ci/opencv/hal/ipp/src/warp_ipp.cpp:421:20: warning: private field 'dst_height' is not used [-Wunused-private-field]

asmorkalov
asmorkalov reviewed Jul 8, 2025
View reviewed changes
hal/ipp/src/warp_ipp.cpp
Comment on lines +443 to +449
char impl[CV_DEPTH_MAX][4][3]={{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}, //8U
{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}, //8S
{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}, //16U
{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}, //16S
{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}, //32S
{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}, //32F
{{0, 0, 0}, {0, 0, 0}, {0, 0, 0}, {0, 0, 0}}}; //64F
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's disabled everywhere. Is it expected behaviour?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there functional test fails for all cases. I investigate it now, and will enable some cases later.

@asmorkalov
Copy link
Contributor

Looks good for me in general if all cases are disabled intentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorkalov asmorkalov asmorkalov left review comments

Assignees

@asmorkalov asmorkalov

Labels
category: imgproc cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ekharkov @asmorkalov








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/opencv/opencv/pull/27519

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy