Content-Length: 356544 | pFad | http://github.com/orchidjs/tom-select/pull/913

46 feat: select all options from optgroup | accessibility improvements by lkitzberger · Pull Request #913 · orchidjs/tom-select · GitHub
Skip to content

feat: select all options from optgroup | accessibility improvements #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

lkitzberger
Copy link

New

  • select all options of an optgroup by clicking on the group
  • new setting focusOptionOnOpen
  • new setting closeOnInputClick
  • single select: order of native options should not be changed, unless a new option is created
  • improvements for accessibility and screen reader usage
  • screen reader announces focus option and status of options

Plugin dropdown_input

  • add class hide-placeholder
  • add class placeholder-input
  • set placeholder on initialize

Plugin drag_drop

  • switching order of options with arrow keys is possible
  • added plugin option for setting a drag&drop icon
  • avoid closing the dropdown on drag_drop action
  • open the dropdown if the user clicks on a selected option
  • order of native select should be sorted correctly
  • added touch support for drag&drop plugin

added options wrapperParent and triggerChangeEvent
dropdown_input: added class and styling for hide-placeholder
…roup

Added option "focusOptionOnOpen" to disable auto focus option when dropdown open.
Fixed type of option "searchField"

Added mouseover event listener on dropdown to mark option as active on hover.
Keydown and keyup event set first or last option as active when no option is active.
…ther input field is focused, the autocomplete values popup when the mouse is down on select.
onBlur should only call deactivate when focusInputOnOpen is enabled.
… ist the placeholder input from the dropdown_input plugin

dropdown_input plugin
- add class "placeholder-input" to the placeholder input

virtual_scroll plugin
- added option "clearDropdownBeforeLoadCallback" to the plugin
- if option is set to false, the initial Options won't be removed on loading options from api.
- if the target of document mousedown event ist the placeholder input of the dropdown_input plugin, and the dropdown is open, the event need to be preventDefault, else the dropdown will reopen on mouseup.
Always focus option when search query entered.
placeholder for search input is set on initialize
- drag_drop plugin: added switching order with arrow keys
- avoid closing the dropdown on drag_drop action
- open the dropdown if the user clicks on a selected option
…s a new option is created

- drag_drop: order of native select should be sorted correctly
…dropdown stays open on drag/drop action

add keydown event for tab to allow closing the dropdown on tab click
…s active

screen reader should announce selected and not selected option in multi select
aria-selected in multiselect should be used for selected options, not active options
…opdown_input is initially focused

added a new setting labelId for referencing
@ericscales
Copy link

@nwalters512 what's needed to get this one merged?

@kevinpapst
Copy link

I am not involved in this project, this is just some random feedback from some random guy:

  • This PR adds a bunch of features at once, which is usually not a good idea (it's easier for the developer, but worse for the maintainer - and therefor makes it less likely to be merged)
  • Most changes are not covered in tests
  • Existing tests were changed, which could be an indication of an undocumented BC break
  • There are 7 new options, but not a single change in the doc_src folder

Recommendation: split this PR into several small PRs that can be verified more easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/orchidjs/tom-select/pull/913

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy