-
-
Notifications
You must be signed in to change notification settings - Fork 141
feat: select all options from optgroup | accessibility improvements #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lkitzberger
wants to merge
22
commits into
orchidjs:master
Choose a base branch
from
lkitzberger:tomselect-additions-modifications
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: select all options from optgroup | accessibility improvements #913
lkitzberger
wants to merge
22
commits into
orchidjs:master
from
lkitzberger:tomselect-additions-modifications
+276
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added options wrapperParent and triggerChangeEvent dropdown_input: added class and styling for hide-placeholder
…roup Added option "focusOptionOnOpen" to disable auto focus option when dropdown open. Fixed type of option "searchField" Added mouseover event listener on dropdown to mark option as active on hover. Keydown and keyup event set first or last option as active when no option is active.
…ther input field is focused, the autocomplete values popup when the mouse is down on select.
onBlur should only call deactivate when focusInputOnOpen is enabled.
… ist the placeholder input from the dropdown_input plugin dropdown_input plugin - add class "placeholder-input" to the placeholder input virtual_scroll plugin - added option "clearDropdownBeforeLoadCallback" to the plugin - if option is set to false, the initial Options won't be removed on loading options from api.
- if the target of document mousedown event ist the placeholder input of the dropdown_input plugin, and the dropdown is open, the event need to be preventDefault, else the dropdown will reopen on mouseup.
Always focus option when search query entered.
…side the wrapper or dropdown.
…ion for optgroup-header
placeholder for search input is set on initialize
- drag_drop plugin: added switching order with arrow keys - avoid closing the dropdown on drag_drop action - open the dropdown if the user clicks on a selected option
…s a new option is created - drag_drop: order of native select should be sorted correctly
…dropdown stays open on drag/drop action add keydown event for tab to allow closing the dropdown on tab click
…s active screen reader should announce selected and not selected option in multi select aria-selected in multiselect should be used for selected options, not active options
…opdown_input is initially focused added a new setting labelId for referencing
@nwalters512 what's needed to get this one merged? |
I am not involved in this project, this is just some random feedback from some random guy:
Recommendation: split this PR into several small PRs that can be verified more easily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
focusOptionOnOpen
closeOnInputClick
Plugin dropdown_input
hide-placeholder
placeholder-input
Plugin drag_drop