Content-Length: 294856 | pFad | http://github.com/pguedes/gesticle/pull/8

56 Pinch update by Alsan · Pull Request #8 · pguedes/gesticle · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinch update #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pinch update #8

wants to merge 3 commits into from

Conversation

Alsan
Copy link
Contributor

@Alsan Alsan commented Nov 11, 2020

Most of the changes are due to my code formatter, therefore, i would prefer merge code manually.

The code actual take effects are:

  1. add #[derive(Copy, Clone)] to SwipeGesture and PinchGesture;
  2. change update method of PinchBuilder
  3. change GesturePinchEvent::Update event handler

@@ -0,0 +1,8 @@
{
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep IDE files out of the repo by adding them to .gitignore

i did that for my files (.idea)

None => warn!("cancelled or unrecognized gesture {:?}", p)
}
Ok(p) => match p.gesture_type() {
Some(t) => (self.gesture_action)(t),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

triggering action on every libinput update works... but is not a smooth approach... also not sure what impact in performance this will have because we are trying to trigger actions many many times per second which i guess is not even very useful in most GUI interactions

so i guess we need some configurability for action triggers - action will be triggered at libinput gesture end or (for the swipe to zoom case) on a certain step

@pguedes
Copy link
Owner

pguedes commented Nov 17, 2020

@Alsan i did a bit of hacking... based on your changes.

have a look at this branch: https://github.com/pguedes/gesticle/tree/Alsan-pinch-update

run it if u can to see if it works for you... and let me know

@pguedes pguedes linked an issue Nov 17, 2020 that may be closed by this pull request
@Alsan
Copy link
Contributor Author

Alsan commented Nov 20, 2020

Works pretty good under terminal, but not that good for the stupid chromium and vscode. I'm looking for a custom zoom control plugin, but not found yet, might need to write it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support spliting a gesture into multiple actions
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/pguedes/gesticle/pull/8

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy