-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pinch update #8
base: master
Are you sure you want to change the base?
Pinch update #8
Conversation
@@ -0,0 +1,8 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please keep IDE files out of the repo by adding them to .gitignore
i did that for my files (.idea)
None => warn!("cancelled or unrecognized gesture {:?}", p) | ||
} | ||
Ok(p) => match p.gesture_type() { | ||
Some(t) => (self.gesture_action)(t), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
triggering action on every libinput update works... but is not a smooth approach... also not sure what impact in performance this will have because we are trying to trigger actions many many times per second which i guess is not even very useful in most GUI interactions
so i guess we need some configurability for action triggers - action will be triggered at libinput gesture end or (for the swipe to zoom case) on a certain step
@Alsan i did a bit of hacking... based on your changes. have a look at this branch: https://github.com/pguedes/gesticle/tree/Alsan-pinch-update run it if u can to see if it works for you... and let me know |
Works pretty good under terminal, but not that good for the stupid chromium and vscode. I'm looking for a custom zoom control plugin, but not found yet, might need to write it myself. |
Most of the changes are due to my code formatter, therefore, i would prefer merge code manually.
The code actual take effects are:
#[derive(Copy, Clone)]
toSwipeGesture
andPinchGesture
;update
method ofPinchBuilder
GesturePinchEvent::Update
event handler