Content-Length: 280903 | pFad | http://github.com/pre-commit/pre-commit/pull/3403

5E Add bun as a supported language. by mrswats · Pull Request #3403 · pre-commit/pre-commit · GitHub
Skip to content

Add bun as a supported language. #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mrswats
Copy link

@mrswats mrswats commented Feb 16, 2025

This PR implements bun as a new language.

Closes #3089

@mrswats
Copy link
Author

mrswats commented Feb 16, 2025

Still a WIP. Working on the tests. I pushed before realizing I was missing a couple of things.

@mrswats
Copy link
Author

mrswats commented Feb 19, 2025

Okay, I need some help. I am not sure what tests to write because I feel like node and npm are a bit quirky and some of the tests are meant to reflect that but with bun I am not super sure what to do.

One thing I noticed is that I do not know how to run binary executables defined in packages.json. The docs say you need to run bun x but I think this is not for a local repo but rather a remote repo.

So I am a bit lost, here and any help would be very appreciated.

@asottile
Copy link
Member

yeah admittedly I'm not super familiar with how bun works but I'm pretty sure as written this won't work generally

somehow need to have bun install the dependencies into the bun_env directory and then execute from there. I'm not sure (?) if there needs to be nodeenv involved (since I thought bun was its own node executable?) -- and I'm even less familiar with executing things with bun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow using bun instead of node
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/pre-commit/pre-commit/pull/3403

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy