Content-Length: 248159 | pFad | http://github.com/pydicom/pydicom/pull/2204

2A Fix SourceImageSequences of two test files by CPBridge · Pull Request #2204 · pydicom/pydicom · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SourceImageSequences of two test files #2204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CPBridge
Copy link
Contributor

Describe the changes

Two Secondary Capture test files have incorrect attributes within their Source Image Sequences. The attributes should be "ReferencedSOPClassUID" and "ReferencedSOPInstanceUID", but "SOPClassUID" and "SOPInstanceUID" have been incorrectly used instead. The images in question are SC_rgb_small_odd.dcm and SC_rgb_small_odd_big_endian.dcm. Strangely enough, though there are several other similar test files, the others do not have this issue (either they use the correct attributes or they do not have the SourceImageSequence).

The relevant part of the standard is Part 3 Section 10.8.

This PR simply updates the two test files to replace the incorrect attribute tags with the correct ones.

Tasks

  • Unit tests added that reproduce the issue or prove feature is working
  • Fix or feature added
  • Code typed and mypy shows no errors
  • Documentation updated (if relevant)
    • No warnings during build
    • Preview link (CircleCI -> Artifacts -> doc/_build/html/index.html)
  • Unit tests passing and overall coverage the same or better

Copy link
Member

@mrbean-bremen mrbean-bremen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! These files have been created using scripts, probably there has been an error in one of the scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/pydicom/pydicom/pull/2204

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy