gh-125631: Enable setting persistent_id and persistent_load of pickler and unpickler #125724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
changed the title
…pickler and unpickler pickle.Pickler and pickle.Unpickler instances have now managed dicts. Arbitrary instance attributes, including persistent_id and persistent_load, can now be set.
serhiy-storchaka
force-pushed
the
pickler-unpickler-dict
branch
from
322e2aa to
ed1ae03
Compare
rruuaanng
reviewed
Oct 19, 2024
| p = _pickle.Pickler(io.BytesIO()) | ||
| self.assertEqual(object.__sizeof__(p), basesize) | ||
| MT_size = struct.calcsize('3nP0n') | ||
| ME_size = struct.calcsize('Pn0P') | ||
| check = self.check_sizeof | ||
| check(p, basesize + | ||
| 2 * P + # Managed dict |
There was a problem hiding this comment.
I prefer it to be more aligned. like this
check(p, basesize +
2 * P +
....
This suggestion applies to all changes.
|
Closed in favor of #125752. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pickle.Pickler and pickle.Unpickler instances have now managed dicts. Arbitrary instance attributes, including persistent_id and persistent_load, can now be set.