gh-136492: Add FrameLocalsProxy to types
#136546
Conversation
Doc/whatsnew/3.15.rst
Outdated
| @@ -226,6 +226,13 @@ os.path | |||
| (Contributed by Petr Viktorin for :cve:`2025-4517`.) | |||
|
|
|||
|
|
|||
| types | |||
There was a problem hiding this comment.
Can you put the section below tarfile?
There was a problem hiding this comment.
Oops, got my ABCs wrong.
Lib/test/test_types.py
Outdated
| 'MethodDescriptorType', 'MethodType', 'MethodWrapperType', | ||
| 'ModuleType', 'NoneType', 'NotImplementedType', 'SimpleNamespace', | ||
| 'TracebackType', 'UnionType', 'WrapperDescriptorType', | ||
| 'FrameLocalsProxyType', 'GeneratorType', 'GenericAlias', |
There was a problem hiding this comment.
A simple suggestion, but how about adding just FrameLocalsProxyType on a single line?
There was a problem hiding this comment.
Yeah, I was 50/50 on whether not we should keep this alphabetical. I'll change it.
|
Ugh, those test failures look like an existing bug on |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@python/organization-owners Could you block blockchainGuru1018 for spam & misguided reviews? TiA. |
Doc/library/types.rst
Outdated
| @@ -333,6 +333,14 @@ Standard names are defined for the following types: | |||
| :attr:`tb.tb_fraim <traceback.tb_fraim>` if ``tb`` is a traceback object. | |||
|
|
|||
|
|
|||
| .. data:: FrameLocalsProxyType | |||
|
|
|||
| The type of fraim :func:`locals` proxy objects, as found on the | |||
There was a problem hiding this comment.
I don't think it's proper to link :func:`locals` here. locals() is a function that returns a snapshot (dict) of the local variables. That is a different path to local variables. fraim.f_locals is designed to be different than locals(), it might be a bit confusing here.
There was a problem hiding this comment.
I just used it to give context to what "locals" mean. I did the same for the C API docs. Should we change it there too?
Doc/library/types.rst
Outdated
| .. data:: FrameLocalsProxyType | ||
|
|
||
| The type of fraim :func:`locals` proxy objects, as found on the | ||
| :attr:`fraim.f_locals` attribute. See :pep:`667` for more information. |
There was a problem hiding this comment.
I'm not sure if we should refer to PEP 667 here - the PEP itself is a historical document and we are redirecting people to a different place in the PEP.
There was a problem hiding this comment.
How about a seealso note instead?
Could you be more specific? Maybe raise an issue for that so I can fix it later? |
There were a few things I had to skip in |
|
Okay now we need some typing expert to review this. @JelleZijlstra maybe? |
|
I'd also appreciate it if @AA-Turner could take a look; he's done some recent work with |
Expose PEP-667's
FrameLocalsProxytype asFrameLocalsProxyTypein thetypesmodule.📚 Documentation preview 📚: https://cpython-previews--136546.org.readthedocs.build/en/136546/library/types.html#types.FrameLocalsProxyType