Content-Length: 499056 | pFad | http://github.com/python/cpython/pull/136548

EB gh-89083: Add CLI tests for `UUIDv{6,7,8}` by LamentXU123 · Pull Request #136548 · python/cpython · GitHub
Skip to content

gh-89083: Add CLI tests for UUIDv{6,7,8} #136548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-89083: Add CLI tests for UUIDv{6,7,8} #136548

wants to merge 13 commits into from
+31 −2

Conversation

LamentXU123
Copy link
Contributor

@LamentXU123 LamentXU123 commented Jul 11, 2025 •
edited
Loading

This PR add simple cli test cases to UUIDv6, v7, v8 added in #89083 , as well as a test case to UUID v1.

There are only one test cases for each, since they can't be customized through CLI.

Skipping news ;)

@bedevere-app bedevere-app bot added awaiting review tests Tests in the Lib/test dir labels Jul 11, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 11, 2025
Closed
@LamentXU123 LamentXU123 changed the title gh-89083: add cli tests for new UUID versions gh-89083: Add cli tests for new UUID versions Jul 11, 2025
picnixz
picnixz reviewed Jul 11, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you:

  • follow PEP-8 (1 blank line between functions)
  • make a separate class that is only testing the CLI functionality please?

@LamentXU123 LamentXU123 requested a review from picnixz July 11, 2025 16:11
@LamentXU123
Copy link
Contributor Author

LamentXU123 commented Jul 11, 2025 •
edited
Loading

follow PEP-8 (1 blank line between functions)
make a separate class that is only testing the CLI functionality please?

Done. Thanks!

Edited: btw, we've got tested like this:

class TestUUIDWithoutExtModule(BaseTestUUID, unittest.TestCase):
    uuid = py_uuid

In this current PR code, this test in redundant. I suggest maybe we could combine them together (?)

LamentXU123
LamentXU123 commented Jul 11, 2025
View reviewed changes
Lib/test/test_uuid.py Outdated
@@ -1140,6 +1140,9 @@ def test_uuid_weakref(self):
weak = weakref.ref(strong)
self.assertIs(strong, weak())


class TestUUIDCli(BaseTestUUID, unittest.TestCase):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need all CAPS on term CLI?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check how other classes testing CLIs are named.

picnixz
picnixz reviewed Jul 11, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of duplicated code. I would sugfgest having a single a single function that tests the expected outputs accordingly:

def do_test_standalone_uuid(self, version):
    stdout = io.StringIO()
    with contextlib.redirect_stdout(stdout):
        self.uuid.main()
    output = stdout.getvalue().strip()
    u = self.uuid.UUID(output)
    self.assertEqual(output, str(u))
    self.assertEqual(u.version, version)

@mock.patch.object(sys, "argv", ["", "-u", "uuid1"])
def test_uuid1(self):
    self.do_test_standalone_uuid(1)

and similar stuff for v6, v7 and v8.

@LamentXU123
Copy link
Contributor Author

follow PEP-8 (1 blank line between functions)
make a separate class that is only testing the CLI functionality please?

Done. Thanks!

Edited: btw, we've got tested like this:

class TestUUIDWithoutExtModule(BaseTestUUID, unittest.TestCase):
    uuid = py_uuid

In this current PR code, this test in redundant. I suggest maybe we could combine them together (?)

In the test case of cli we've actually already tested UUID without ext moudle (?, I'm not quiet sure) So maybe combining them together will be better?

picnixz
picnixz reviewed Jul 11, 2025
View reviewed changes
Lib/test/test_uuid.py Outdated
@@ -1140,6 +1140,9 @@ def test_uuid_weakref(self):
weak = weakref.ref(strong)
self.assertIs(strong, weak())


class TestUUIDCli(BaseTestUUID, unittest.TestCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check how other classes testing CLIs are named.

@picnixz
Copy link
Member

picnixz commented Jul 11, 2025

In the test case of cli we've actually already tested UUID without ext moudle (?, I'm not quiet sure) So maybe combining them together will be better?

In this current PR code, this test in redundant. I suggest maybe we could combine them together (?)

It's not entirely redundant. However I see the issue. Two possibilities:

  • Make the CLI test a mixin class that doesn't inherit from test case
  • Create two subclasses that are test cases, one with the extension module, one without.

Or:

  • Make CLI tests a mixin class that doesn't inhert from test cases, without a uuid field (you can add a dummy one just for autocompletion, but set it to None as it'll be subclassed later).
  • Make TestUUIDWithoutExtModule and TestUUIDWithExtModule inherit from this mixin as well (in addition to BaseTestUUID).

@picnixz
Copy link
Member

picnixz commented Jul 11, 2025 •
edited
Loading

Ok, actually CommandLineTest is a more common name in the code base. Just use it, no need to mention UUID (search for "CommandLineTest" and you'll see)

@LamentXU123
Copy link
Contributor Author

Ok, actually CommandLineTest is a more common name in the code base. Just use it, no need to mention UUID (search for "CommandLineTest" and you'll see)

The test classes before are named in testUUID* (which I think would be better if we add this prefix in this func). But yes CommandLineTest only is more common one in the code base so it's OK.

@LamentXU123
Copy link
Contributor Author

Make the CLI test a mixin class that doesn't inherit from test case
Create two subclasses that are test cases, one with the extension module, one without.

This is better IMO. I've changed it.

picnixz
picnixz reviewed Jul 11, 2025
View reviewed changes
@LamentXU123 @picnixz
Update Lib/test/test_uuid.py
a873bf8 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
picnixz reviewed Jul 11, 2025
View reviewed changes
@picnixz picnixz changed the title gh-89083: Add cli tests for new UUID versions gh-89083: Add CLI tests for UUIDv{6,7,8} Jul 11, 2025
@picnixz picnixz changed the title gh-89083: Add CLI tests for UUIDv{6,7,8} gh-89083: Add CLI tests for UUIDv{6,7,8} Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz approved these changes

Assignees
No one assigned
Labels
awaiting merge skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LamentXU123 @picnixz @StanFromIreland








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/python/cpython/pull/136548

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy