gh-116738: Make syslog module thread-safe #136760
Open
+53
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
setlogmask()
function in thesyslog
module thread-safe. These changes are relevant for scenarios where the GIL is disabled or when using subinterpreters.syslog()
,openlog()
, andcloselog()
in the syslog module are already handled for FT-Python using the@critical_section
on themodule
. However, there might be an issue withsyslog()
for subinterpreters on macOS.cpython/Modules/syslogmodule.c
Lines 242 to 245 in 03017a8
I will check/test the macOS subinterpreter and create a separate PR if necessary.
cc: @mpage @colesbury