Content-Length: 297433 | pFad | http://github.com/python/cpython/pull/136939

82 gh-136938: Do not use `var` in js, use `let` and `const` by sobolevn · Pull Request #136939 · python/cpython · GitHub
Skip to content

gh-136938: Do not use var in js, use let and const #136939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 21, 2025

@sobolevn
Copy link
Member Author

!buildbot emscripten

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 69e0d6c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136939%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR

@hoodmane
Copy link
Contributor

The change to Python/sysmodule.c looks good to me. As far as Python/emscripten_syscalls.c, I think I'd prefer to keep the code as close as possible to the reference Emscripten code which uses var.

@freakboy3742
Copy link
Contributor

Agree with @hoodmane - it makes sense to clean up the "Python internal" usage; but when there's code being synchronised with upstream, we should (to the extent possible) keep the var/let/const usage consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/python/cpython/pull/136939

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy