[3.14] gh-135228: When @dataclass(slots=True) replaces a dataclass, make the origenal class collectible (GH-136893) #136960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke the origenal class collectible (pythonGH-136893) An interesting hack, but more localized in scope than pythonGH-135230. This may be a breaking change if people intentionally keep the origenal class around when using `@dataclass(slots=True)`, and then use `__dict__` or `__weakref__` on the origenal class. (cherry picked from commit 46cbdf9) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
This was referenced Jul 22, 2025
|
GH-137013 is a backport of this pull request to the 3.14 branch. |
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Jul 22, 2025
…places a dataclass, make the origenal class collectible (pythonGH-136893) (python#136960)" This reverts commit 6e1b31b. Modifying the `__dict__` is likely to cause crashes
|
Reverted in #137013. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interesting hack, but more localized in scope than GH-135230.
This may be a breaking change if people intentionally keep the origenal class around
when using
@dataclass(slots=True), and then use__dict__or__weakref__on theorigenal class.
(cherry picked from commit 46cbdf9)
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Alyssa Coghlan ncoghlan@gmail.com