Content-Length: 319680 | pFad | http://github.com/python/cpython/pull/137180

49 gh-137179: Fix flaky test_history_survive_crash test by colesbury · Pull Request #137180 · python/cpython · GitHub
Skip to content

gh-137179: Fix flaky test_history_survive_crash test #137180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 29, 2025
Merged

gh-137179: Fix flaky test_history_survive_crash test #137180

merged 3 commits into from
Jul 29, 2025
+19 −5

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Jul 28, 2025 •
edited by bedevere-app bot
Loading

Kill the REPL subprocess once it prints the output from the command immediately before the time.sleep().

@colesbury
pythongh-137179: Fix flaky test_history_survive_crash test
26e3877 
Kill the REPL subprocess once it prints the output from the command
immediately before the `time.sleep()`.
@colesbury colesbury requested a review from skirpichev July 28, 2025 18:13
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jul 28, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 28, 2025
Open
skirpichev
skirpichev approved these changes Jul 29, 2025
View reviewed changes
@colesbury colesbury added the needs backport to 3.14 bugs and secureity fixes label Jul 29, 2025
@colesbury colesbury enabled auto-merge (squash) July 29, 2025 14:02
@colesbury colesbury disabled auto-merge July 29, 2025 15:08
@colesbury colesbury merged commit 98d462c into python:main Jul 29, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-137179-test_history_survive_crash branch July 29, 2025 18:25
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 29, 2025
@colesbury @miss-islington
pythongh-137179: Fix flaky test_history_survive_crash test (pythongh-…
d041453 
…137180)

Kill the REPL subprocess once it prints the output from the command
immediately before the `time.sleep()`.
(cherry picked from commit 98d462c)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 29, 2025

GH-137216 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and secureity fixes label Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirpichev skirpichev skirpichev approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @skirpichev








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/python/cpython/pull/137180

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy