gh-87281: Fix support for locales with modifiers #137253
Draft
+169
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
locale-modifiers
branch
from
11fce5c to
853cfbd
Compare
|
Tests crash on Windows. See #137273. |
Comment on lines
487
to
+491
| if modifier == 'euro' and '.' not in code: | ||
| # Assume Latin-9 for @euro locales. This is bogus, | ||
| # since some systems may use other encodings for these | ||
| # locales. Also, we ignore other modifiers. | ||
| return code, 'iso-8859-15' | ||
| # locales. | ||
| return code + '@euro', 'ISO8859-15' |
There was a problem hiding this comment.
This may be a dead code, because normalize() above adds encoding.
serhiy-storchaka
force-pushed
the
locale-modifiers
branch
from
1013430 to
abcbb93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.