Content-Length: 294643 | pFad | http://github.com/python/mypy/pull/19077

45 Make stubtest ignore `__slotnames__` by ngnpope · Pull Request #19077 · python/mypy · GitHub
Skip to content

Make stubtest ignore __slotnames__ #19077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Conversation

ngnpope
Copy link
Contributor

@ngnpope ngnpope commented May 12, 2025

This is a cached list of names of slots added by the copyreg module.

See typeddjango/django-stubs#2584 for a case of these cropping up in django-stubs.

This is a cached list of names of slots added by the `copyreg` module.

See typeddjango/django-stubs#2584 for a case of
these cropping up in `django-stubs`.
@ngnpope
Copy link
Contributor Author

ngnpope commented May 12, 2025

Ping @sobolevn 👋🏻

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of stubtest ignores for this! 👍

I will keep this open for a week or so, for others to comment. Ping me in a week to merge this, please, if there are no other opinions :)

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, seems like this is called from the language core, just implemented in copyreg.

@sobolevn sobolevn merged commit addcff2 into python:master May 12, 2025
12 checks passed
@ngnpope ngnpope deleted the stubtest-slotnames branch May 12, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/python/mypy/pull/19077

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy