[libc++ readiness][caffe2] No reason to check for "ext/stdio_filebuf.h" #154080
Conversation
|
This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @yuxuanchen1997, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154080
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dd75884 with merge base d1fe198 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
|
This pull request was exported from Phabricator. Differential Revision: D75179136 |
|
@pytorchbot label "topic: not user facing" |
yuxuanchen1997
force-pushed
the
export-D75179136
branch
from
845654d to
e093053
Compare
…h" (pytorch#154080) Summary: There should be no reason to check for existence of this GNU C++ header here in this file. It doesn't include it. Removing this condition makes adfinder linkable under libc++ platform. Test Plan: CI, and build adfinder. Differential Revision: D75179136
|
This pull request was exported from Phabricator. Differential Revision: D75179136 |
…h" (pytorch#154080) Summary: Pull Request resolved: pytorch#154080 There should be no reason to check for existence of this GNU C++ header here in this file. It doesn't include it. Removing this condition makes adfinder linkable under libc++ platform. Test Plan: CI, and build adfinder. Differential Revision: D75179136
yuxuanchen1997
force-pushed
the
export-D75179136
branch
2 times, most recently
from
d2e8a6b to
156f2ed
Compare
…h" (pytorch#154080) Summary: There should be no reason to check for existence of this GNU C++ header here in this file. It doesn't include it. Removing this condition makes adfinder linkable under libc++ platform. Test Plan: CI, and build adfinder. Differential Revision: D75179136
…h" (pytorch#154080) Summary: Pull Request resolved: pytorch#154080 There should be no reason to check for existence of this GNU C++ header here in this file. It doesn't include it. Removing this condition makes adfinder linkable under libc++ platform. Test Plan: CI, and build adfinder. Differential Revision: D75179136
|
This pull request was exported from Phabricator. Differential Revision: D75179136 |
yuxuanchen1997
force-pushed
the
export-D75179136
branch
from
156f2ed to
dd75884
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: There should be no reason to check for existence of this GNU C++ header here in this file. It doesn't include it. Removing this condition to make it build under libc++.
Differential Revision: D75179136