unify symbolic_shapes and sizevars dynamic shapes APIs naming 1 #154774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154774
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Unrelated FailuresAs of commit 3323630 with merge base 0f3db20 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
module: inductor
release notes: fx
laithsakka
changed the title
…s namings 1" cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
…s namings 1" cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
laithsakka
changed the title
laithsakka
changed the title
drisspg
reviewed
May 30, 2025
| # asked questions can be answered without guarding otherwise they return False. | ||
| # Those are similar to statically_known_true in symbolic_shapes but operate on sympy expressions | ||
| # instead of symnodes. | ||
| def statically_known_true(self, expr: Union[sympy.Basic, bool]) -> bool: |
There was a problem hiding this comment.
could you also add this in a doc block to this function, also can you keep the Note
There was a problem hiding this comment.
the old note? why would someone be interested in how things were long ago? i found it redundent specially that we still have APIs that guard in the current system like calling evaluate_expr in shapeenv or gaurd_or_false, guard_or_true ..etc
drisspg
reviewed
May 30, 2025
| # Those are similar to statically_known_true in symbolic_shapes but operate on sympy expressions | ||
| # instead of symnodes. | ||
| def statically_known_true(self, expr: Union[sympy.Basic, bool]) -> bool: | ||
| return _statically_known_true(self.shape_env, expr) | ||
|
|
||
| def statically_known_equals( | ||
| self, left: Union[Expr, int], right: Union[Expr, int] | ||
| ) -> bool: | ||
| """ | ||
| Returns a bool indicating if it is sound to optimize as if left and right are equal. |
There was a problem hiding this comment.
I kinda wish all of these said something in a doc block , like `This function does not add guards, if it can determine that the expr left equals right at compile time it will return True, otherwise it will return False. An example when you should use is: a performance optimization that won't hinder correctness, etc...'
…ing 1" Inductor have a set of APIs that allows performing symbolic evaluations similar to that of symbolic shapes but it operates on sympy expressions instead of symnodes. Namings are not consistent making them consistent in this stack. Step 1 : unify statically_know_true naming! for consistent experience. cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov [ghstack-poisoned]
bobrenjc93
approved these changes
Jun 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Inductor have a set of APIs that allows performing symbolic evaluations similar to that of symbolic shapes
but it operates on sympy expressions instead of symnodes. Namings are not consistent making them consistent
in this stack.
Step 1 : unify statically_know_true naming! for consistent experience.
cc @ezyang @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov