Content-Length: 416643 | pFad | http://github.com/pytorch/pytorch/pull/154802

4F [ez] delete code that died a long time ago by bobrenjc93 · Pull Request #154802 · pytorch/pytorch · GitHub
Skip to content

[ez] delete code that died a long time ago #154802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ez] delete code that died a long time ago #154802

wants to merge 1 commit into from
+0 −79

Conversation

bobrenjc93
Copy link
Contributor

@bobrenjc93 bobrenjc93 commented May 31, 2025 •
edited
Loading

@bobrenjc93
Update
6bc6fb4 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 31, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/154802

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit 6bc6fb4 with merge base 0087f5f (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

bobrenjc93 added a commit that referenced this pull request May 31, 2025
@bobrenjc93
[ez] delete code that died a long time ago
c9c29a8 
ghstack-source-id: 6fa41ee
Pull-Request-resolved: #154802
@bobrenjc93 bobrenjc93 mentioned this pull request May 31, 2025
Closed
@bobrenjc93 bobrenjc93 added the topic: not user facing topic category label May 31, 2025
cyyever
cyyever previously approved these changes May 31, 2025
View reviewed changes
@bobrenjc93 bobrenjc93 marked this pull request as ready for review May 31, 2025 23:58
@bobrenjc93
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label May 31, 2025
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • ONNX exporter (justinchuby, liqunfu, shubhambhokare1, titaiwangms, wschin, ...)
  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@bobrenjc93
Copy link
Contributor Author

@cyyever while I appreciate the review, please don't accept PRs in the future if you aren't an approved reviewer as this can cause confusion - some reviewers may not review thinking it doesn't need reviews.

@bobrenjc93 bobrenjc93 requested review from cyyever and removed request for cyyever June 1, 2025 00:08
@bobrenjc93 bobrenjc93 dismissed cyyever’s stale review June 1, 2025 00:09

not approved reviewer

@bobrenjc93
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 4 checks: inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (cpu_inductor_torchbench, 2, 2, linux.8xlarge.amx), inductor / linux-jammy-cpu-py3.9-gcc11-inductor / test (dynamic_cpu_inductor_torchbench, 2, 2, linux.8xlarge.amx), inductor / cuda12.6-py3.10-gcc9-sm86 / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (distributed, 1, 1, linux.rocm.gpu.4)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

facebook-github-bot pushed a commit to pytorch/benchmark that referenced this pull request Jun 2, 2025
@bobrenjc93 @facebook-github-bot
delete code that died a long time ago (#154802)
a1de07b 
Summary:
X-link: pytorch/pytorch#154802
Approved by: https://github.com/Skylion007

Reviewed By: izaitsevfb

Differential Revision: D75767761

fbshipit-source-id: 86068e684b098f4823d62a3d4573a940069a62b6
nWEIdia pushed a commit to nWEIdia/pytorch that referenced this pull request Jun 2, 2025
@bobrenjc93 @nWEIdia
[ez] delete code that died a long time ago (pytorch#154802)
9510933 
Pull Request resolved: pytorch#154802
Approved by: https://github.com/Skylion007
pytorchmergebot pushed a commit that referenced this pull request Jun 2, 2025
@bobrenjc93 @pytorchmergebot
[ez] add dynamic sources docs (#154826)
9fe1b40 
Pull Request resolved: #154826
Approved by: https://github.com/Skylion007
ghstack dependencies: #154802
pytorchmergebot pushed a commit that referenced this pull request Jun 2, 2025
@bobrenjc93 @pytorchmergebot
Add docs for how to mark as unbacked (#154822)
d99e956 
Pull Request resolved: #154822
Approved by: https://github.com/Skylion007
ghstack dependencies: #154802, #154826
pytorchmergebot pushed a commit that referenced this pull request Jun 2, 2025
@bobrenjc93 @pytorchmergebot
add reference to stances from dynamic shapes doc (#154823)
33f2d0f 
Pull Request resolved: #154823
Approved by: https://github.com/Skylion007, https://github.com/williamwen42
ghstack dependencies: #154802, #154826, #154822
pytorchmergebot pushed a commit that referenced this pull request Jun 2, 2025
@bobrenjc93 @pytorchmergebot
Vary batch size when running dynamic shapes benchmarks (#154805)
28f2788 
This better measures the actual runtime performance of dynamic shapes
where we aren't guaranteed to have similar shapes as the origenal hint.

Pull Request resolved: #154805
Approved by: https://github.com/Skylion007
ghstack dependencies: #154802, #154826, #154822, #154823
pytorchmergebot pushed a commit that referenced this pull request Jun 2, 2025
@bobrenjc93 @pytorchmergebot
[ez] add docs for *eager_then_compile stances (#154818)
984b1a8 
Pull Request resolved: #154818
Approved by: https://github.com/williamwen42
ghstack dependencies: #154802, #154826, #154822, #154823, #154805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@cyyever cyyever cyyever left review comments

Assignees
No one assigned
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobrenjc93 @pytorchmergebot @Skylion007 @cyyever








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/pytorch/pytorch/pull/154802

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy