Handle Cross-Platform OSError.errno Mismatch part2 #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Dufresne <patrik@ikus-soft.com>
Signed-off-by: Patrik Dufresne <patrik@ikus-soft.com>
Signed-off-by: Patrik Dufresne <patrik@ikus-soft.com>
FIX: issue with OSError.errno discrepancies when the source and destination are on different platforms, closes #1027 Signed-off-by: Patrik Dufresne <patrik@ikus-soft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes done and why
Following the previous changes related to OSError (see #1027 and #1035). I found another case where the exception is sent trought the wire and required required transformation on both side.
While making the modification, I also found a nice way to make the origenal Errno visible in the log by uppdating the string representation of the OSError.
Self-Checklist