-
Notifications
You must be signed in to change notification settings - Fork 95
[DOC] Add development note for MacOS #1066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smaller things and the "global" fixes should go away. As a side remark, with code changes, you shouldn't use the [DOC]
prefix! Rebase required as well.
|
||
[source,shell] | ||
---- | ||
git clone https://github.com/rdiff-backup/rdiff-backup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want to suggest cloning via HTTPS not SSH (assuming someone wants to code later)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't know. If they'd want to push changes, most would have first to fork then clone. Perhaps worth a small note.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm always using https to clone git repo. Rarely use SSH protocol.
|
||
[source,shell] | ||
---- | ||
python3 -m venv .venv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I create my venv under dist
to avoid having to exclude one more file. Would you mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's a defacto standard to create a virtualenv under ".venv". It's very common and well integrated in vscode. In addition, I've already include .venv to gitignore. 😄
src/rdiff_backup/run_stats.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Global is already fixed.
DOC: Add development note for MacOS Closes #995 Signed-off-by: Patrik Dufresne <patrik@ikus-soft.com>
@ericzolf Thanks for your feedback. I've update the documentation. |
Changes done and why
Create a first version with MacOS documentation.
Self-Checklist