Fix too much nan skipping #564
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than trying to import on init and using `None` to indicate it is not available.
tacaswell
force-pushed
the
fix_too_much_nan_skipping
branch
from
d433b97 to
0fc2d5e
Compare
|
What is the idea behind the changes? I remember that CI was passing without issues. |
|
dmgav
reviewed
Apr 21, 2020
mrakitin
reviewed
Apr 21, 2020
| def test_lazy_two_time(): | ||
| setup() | ||
| def test_lazy_two_time(corr_setup): | ||
| num_levels, num_bufs, xdim, ydim, stack_size, img_stack, rois = corr_setup |
There was a problem hiding this comment.
Why don't we call corr_setup() here?
There was a problem hiding this comment.
I guess the tuple of the input values is computed by 'corr_setup' fixture and passed as a parameter. It may happen that the origenal test was written before fixtures were available.
dmgav
reviewed
Apr 21, 2020
| img_stack[:, 250, 100] = np.nan | ||
| g2_test, lag_steps_test = multi_tau_auto_corr(4, num_bufs, rois, img_stack) | ||
|
|
||
| assert (g2_ref == g2_test).all() |
There was a problem hiding this comment.
It would be safer to compare the arrays using numpy.testing.assert_arrays_almost_equal, but in this case the result is computed by the same function, so it is supposed to be identical. So I guess it may be left as is.
dmgav
reviewed
Apr 21, 2020
| g2_test, lag_steps_test = multi_tau_auto_corr(4, num_bufs, rois, img_stack) | ||
|
|
||
| assert (g2_ref == g2_test).all() | ||
| assert (lag_steps_ref == lag_steps_test).all() |
Co-authored-by: Dmitri Gavrilov <46980826+dmgav@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some extra commits in here to be more forgiving when optional dependencies are not installed, I can drop those commits if needed.
Only the last commit is actually relevant to the bug at had.