[feat] Added shell.nix (Nix development support) #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SuperSandro2000 can you review this PR? .. thanks 👍 |
| Done! | ||
| */ | ||
|
|
||
| (pkgs.buildFHSEnv { |
There was a problem hiding this comment.
Why didn't you use mkShell?
There was a problem hiding this comment.
Didn't let me run the node nvm stuff from the makefile otherwise! I'm on NixOS 24.11 but in case this was a my-config-issue then we can switch it
There was a problem hiding this comment.
Do you still have the error?
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
shell.nixfile. This is not for use in the Nix version of searchx, but instead allows developers to get a compatible development environment in one command.Why is this change important?
Some developers are NixOS based, which cannot run arbitrary executables (e.g. the nvm-based node) by default. The nix-shell wraps it in an FHS environment, which fixes that thanks to Nix magic I do not understand.
How to test this PR locally?
On a device with nix installed, navigate to the repository and run
make test. This will probably not work. Then, runnix-shelland trymake testagain. It should work!