Replace numsymb with pattern matching versions [in progress] #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
requested changes
Nov 30, 2021
src/sicmutils/numsymb-rules
Outdated
| negation of `x`. For boolean `x`, returns the negation of `x`." | ||
| [x] | ||
| (let [RS (r/ruleset | ||
| (? ?x true?) r/=> false |
There was a problem hiding this comment.
I would import => directly so you don't need the slash. If you are matching a literal you can do true => false, or you can write (? ?x boolean?) => (: #(not (% '?x))), I believe.
There was a problem hiding this comment.
do you mean (? #(not (% '?x))) (? instead of :) ?
src/sicmutils/numsymb-rules
Outdated
| ?x r/=> (not ?x))] | ||
| (RS x))) | ||
|
|
||
| ;; basic tests - these should probavbly live elsewhere? |
There was a problem hiding this comment.
see the convention for other namespaces. Put these in tests, same namespace with -test appended.
src/sicmutils/numsymb-rules
Outdated
| (RS x))) | ||
|
|
||
| ;; basic tests - these should probavbly live elsewhere? | ||
| (let [v [true false 1 0 'a '() ()]] |
There was a problem hiding this comment.
(doseq [v ...]
(is (= (sym:not v) ((sym/symbolic-operator 'not) v))))
src/sicmutils/numsymb-rules
Outdated
| (? ?x n:pi-over-4-mod-pi?) r/=> 1 | ||
| (? ?x n:-pi-over-4-mod-pi?) r/=> -1 | ||
| (? ?x n:pi-over-2-mod-pi?) r/=> (u/illegal "Undefined: tan") | ||
| (? ?x v/number?) r/=> (?? #(Math/tan (% '?x))) |
There was a problem hiding this comment.
single ? , not ??, since you are not splicing in a result
There was a problem hiding this comment.
I'm a little confused by the difference; is ?? used for binding collections, whereas ? is for binding "single" variables?
sritchie
force-pushed
the
main
branch
3 times, most recently
from
afa6dd7 to
c33ef42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses sicmutils/placeholder#70 . Currently, the pattern-matching versions of
numsymblive in a different namespacenumsymb-rules. Onlytan,atan,gcdandnotare currently implemented - thought it would be good to ask for feedback in an initial stage to make sure I'm doing this right.Very basic testing throughout the code, presumably these should go somewhere in the
/test/sicmutilsfolder?