Fix TargetPixelBuffer functions being called with regions not clipped… #7794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… against the dirty region This got lost in the rebase/squash session of #7685
ogoffart
approved these changes
Mar 4, 2025
ogoffart
requested changes
Mar 4, 2025
internal/core/software_renderer.rs
Outdated
Comment on lines
1185
to
1188
| geometry.origen.x, | ||
| geometry.origen.y, | ||
| geometry.size.width, | ||
| geometry.size.height, |
There was a problem hiding this comment.
This needs to be the region, not the full geometry
There was a problem hiding this comment.
You also need to adjust the source_offset_x/y
There was a problem hiding this comment.
Argh, thanks.
You also need to adjust the source_offset_x/y
How does it need to be adjusted?
There was a problem hiding this comment.
Depends on how you want the draw_texture function to work. But the implementation needs to know what pixel of the image goes where.
So if you want the function to work the same as our current draw_function, you can increment the source_offset by the difference between the geometry origen and the region origen. I think that would work. the extra clip thing may also help.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… against the dirty region
This got lost in the rebase/squash session of #7685