Extend the use cases demo with translation support #7858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronical
force-pushed
the
simon/usescases-p4-translations
branch
from
e7fc177 to
b14d412
Compare
FloVanGH
approved these changes
Mar 14, 2025
ogoffart
approved these changes
Mar 14, 2025
|
|
||
| By default, the domain used for translations is the name of the CMake target the `.slint` files are targeted with. | ||
| Use the `SLINT_TRANSLATION_DOMAIN` target property to override this and use the specified value as domain, instead. | ||
| This is useful in build environments where the target name is given and not suitable, such as esp-idf. |
There was a problem hiding this comment.
This is useful in many other case. Not sure if mentioning esp-idf here is worth it. But I guess it doesn't hurt
| @@ -42,4 +42,6 @@ export component App inherits Window { | |||
| changed height => { | |||
| DialogGlobal.window-height = root.height; | |||
| } | |||
|
|
|||
| out property <string> trick-to-include-german-umlauts: "äöüÄÖÜ"; // required for translations | |||
There was a problem hiding this comment.
This sucks 😞
We need a better way to tell the Slint compiler what ranges we include.
Alternatively, we should have the slint compiler look at the bundled string.
Anyway, I guess right now we have to keep that for the example.
There was a problem hiding this comment.
Alternatively, we should have the slint compiler look at the bundled string.
Yes indeed.
.github/workflows/nightly_tests.yaml
Outdated
| @@ -66,7 +66,7 @@ jobs: | |||
| - name: Downgrade cc and ring crate to work around https://github.com/slint-ui/slint/issues/6875 | |||
| run: | | |||
| cargo update -p ring --precise 0.17.9 | |||
| cargo update -p cc --precise 1.1.31 | |||
| cargo update -p cc --precise 1.2.16 | |||
There was a problem hiding this comment.
That's indeed unrelated and from another change. Oops.
… property This is useful in environments such as esp-idf, where the component name is something awkward like __esp_idf_main or so.
tronical
force-pushed
the
simon/usescases-p4-translations
branch
from
b14d412 to
6a365ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.