Add a brush widgets into the live-preview #7859
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunger
requested review from
FloVanGH and
ogoffart
and removed request for
FloVanGH
hunger
force-pushed
the
tobias/push-vxvtumlrzrzy
branch
from
1aaf170 to
fdc7263
Compare
Add gradients to the list of types that can be read from JSON and serialized to JSON.
... and add helper code to enable the backend to set/show Brush information.
... including adding/removing values and such. Whoho.
It got *WAY* to big.
It now works, provided the first thing you do is to drag one of the color sliders ;-)
hunger
force-pushed
the
tobias/push-vxvtumlrzrzy
branch
from
6847819 to
13f055f
Compare
szecket
reviewed
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt at a brush widget. It still has several problems (I would not want this in 1.10.1 in this state!).
Problems:
I also expect some opposition to the JSON representation for our gradients I picked in the first change: I wanted something machine-readable for those, while we go for strings elsewhere.