Fix Anthropic FIM with muxing. #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the context of muxing, the code determining which mapper to use when receiving requests to be routed towards Anthropic was relying in `is_fim_request` only, and was not taking into account if the actual endpoint receiving the request was the legacy one (i.e. `/completions`) or the current one (i.e. `/chat/completions`). This caused the use of the wrong mapper, which led to an empty text content for the FIM request. A better way to determine which mapper to use is looking at the effective type, since that's the real source of truth for the translation.
|
OK, a re-run of Anthropic integration tests was successful. |
jhrozek
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of muxing, the code determining which mapper to use when receiving requests to be routed towards Anthropic was relying in
is_fim_requestonly, and was not taking into account if the actual endpoint receiving the request was the legacy one (i.e./completions) or the current one (i.e./chat/completions). This caused the use of the wrong mapper, which led to an empty text content for the FIM request.A better way to determine which mapper to use is looking at the effective type, since that's the real source of truth for the translation.