-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error occured while creating symlink admin frontend build #7365
Comments
This was fixed in #7364, but the test look like it's blocked |
Thank you for the info @cteliberty , should i leave this issue open, until the change is available, or should i close it? |
@alexander-schranz Is there a problem with the test? The tests seems no longer progressing. @dduenker I don't know. |
A release is planned for this days. Still you can patch the file manually to unblock it:
diff --git a/symlink-vendor-directory.js b/symlink-vendor-directory.js
index d33c78010f0..7c502c98d3b 100644
--- a/symlink-vendor-directory.js
+++ b/symlink-vendor-directory.js
@@ -33,7 +33,7 @@ if (
&& path.basename(path.dirname(process.cwd())) === 'assets'
)
) {
- exec('npx symlink-dir ' + from + ' ' + to, (error) => {
+ exec('npx "symlink-dir@<6.0" ' + from + ' ' + to, (error) => {
if (error) {
throw new Error('Error occured while creating symlink: ' + error);
} Unreleased version of sulu/sulu can also be installed using: composer require sulu/sulu:"2.4.*@dev"
composer require sulu/sulu:"2.5.*@dev" |
Thanks! This had me stumped for a while and I was frantically trying to update the admin JS dependencies to Node 18... |
Another issue appeared and we decided to downgrade the symlink package in: #7504 |
Actual Behavior
Building the admin frontend currently fails, because the command "npx symlink-dir" uses the latest release of symlink-dir.
The latest version of this requires node >= 18.12 now, whereas the sulu frontend requires node 14.
breaking change: pnpm/symlink-dir@55fd697
Expected Behavior
Building the frontend does not fail
Steps to Reproduce
Build manually as described on https://docs.sulu.io/en/latest/cookbook/build-admin-frontend.html#common-errors
Possible Solutions
pin the used symlink-dir to a version before 6.0.0
The text was updated successfully, but these errors were encountered: