Content-Length: 261736 | pFad | https://github.com/sulu/sulu/pull/7504

05 Fix compatibility to Node 14 and 16 and NPM 6 by alexander-schranz · Pull Request #7504 · sulu/sulu · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility to Node 14 and 16 and NPM 6 #7504

Merged

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Jul 4, 2024

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets similar to #7365
Related issues/PRs zkochan/packages#194
License MIT
Documentation PR sulu/sulu-docs#

What's in this PR?

Fix compatibility to Node 14 and 16 and NPM 6.

Why?

Error: Error occured while creating symlink: Error: Command failed: npx "symlink-dir@<6.0" ../../vendor node_modules/@sulu/vendor
Users/alexanderschranz/Documents/Projects/sulu-develop.localhost/vendor/sulu/sulu/symlink-vendor-directory.js:38
            throw new Error('Error occured while creating symlink: ' + error);
            ^

Error: Error occured while creating symlink: Error: Command failed: npx "symlink-dir@<6.0" ../../vendor node_modules/@sulu/vendor
npm ERR! code ENOTSUP
npm ERR! notsup Unsupported engine for rename-overwrite@5.0.1: wanted: {"node":">=18"} (current: {"node":"14.21.3","npm":"6.14.18"})
npm ERR! notsup Not compatible with your version of node/npm: rename-overwrite@5.0.1
npm ERR! notsup Not compatible with your version of node/npm: rename-overwrite@5.0.1
npm ERR! notsup Required: {"node":">=18"}
npm ERR! notsup Actual:   {"npm":"6.14.18","node":"14.21.3"}

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/alexanderschranz/.npm/_logs/2024-07-04T12_51_25_341Z-debug.log
Die Installation von [ 'symlink-dir@<6.0' ] ist mit dem Code 1 fehlgeschlagen

    at /Users/alexanderschranz/Documents/Projects/sulu-develop.localhost/vendor/sulu/sulu/symlink-vendor-directory.js:38:19
    at ChildProcess.exithandler (child_process.js:390:5)
    at ChildProcess.emit (events.js:400:28)
    at maybeClose (internal/child_process.js:1088:16)
    at Socket.<anonymous> (internal/child_process.js:446:11)
    at Socket.emit (events.js:400:28)
    at Pipe.<anonymous> (net.js:686:12)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! sulu-skeleton@ preinstall: `node ../../vendor/sulu/sulu/preinstall.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the sulu-skeleton@ preinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/alexanderschranz/.npm/_logs/2024-07-04T12_51_25_426Z-debug.log


 [ERROR] Unexpected error while installing npm dependencies.

This is caused as a new version rename-overwrite was released which causes now issues on node 14:

Unsupported engine for rename-overwrite@5.0.1: wanted: {"node":">=18"} (current: {"node":"14.21.3","npm":"6.14.18"})

Downgrading to a legacy version may not required if the change is reverted. See zkochan/packages#194 for issue on the rename-overwrite package.

@alexander-schranz alexander-schranz added the Bug Error or unexpected behavior of already existing functionality label Jul 4, 2024
@Prokyonn Prokyonn merged commit 443ddbe into sulu:2.5 Jul 4, 2024
8 checks passed
@alexander-schranz alexander-schranz deleted the bugfix/node-14-16-compatibility branch July 5, 2024 05:21
@stollr
Copy link
Contributor

stollr commented Jul 5, 2024

Thanks for the fast fix. We ran into the issue yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/sulu/sulu/pull/7504

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy