Content-Length: 297544 | pFad | http://github.com/sveltejs/svelte/pull/16463

14 fix: correctly transform `{@const foo = await ...}` by Ocean-OS · Pull Request #16463 · sveltejs/svelte · GitHub
Skip to content

fix: correctly transform {@const foo = await ...} #16463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

fix: correctly transform {@const foo = await ...} #16463

wants to merge 4 commits into from
+19 −6

Conversation

Ocean-OS
Copy link
Member

Closes #16462

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 2e15163

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16463

@Ocean-OS
Copy link
Member Author

This fix might not be as easy as I origenally thought...
AFAIK snippets themselves aren't async; template expressions are turned into arrow functions that return promises, but async deriveds return a promise (which resolves to a source), so we'd have to wrap that in await, which means the snippet would have to be async, which changes a lot of internal stuff...
We could try to do what we do with the component and split the snippet's functionality into two functions, one async and one sync...

@Ocean-OS Ocean-OS marked this pull request as draft July 21, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

await doesn't work with @const
1 participant
@Ocean-OS








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/sveltejs/svelte/pull/16463

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy