[HttpClient] Fix uploading files > 2GB #59654
Conversation
| @@ -316,6 +316,9 @@ public function request(string $method, string $url, array $options = []): Respo | |||
| } | |||
|
|
|||
| foreach ($curlopts as $opt => $value) { | |||
| if (\CURLOPT_INFILESIZE === $opt && $value >= 1 << 31) { | |||
| $opt = 115; // 115 === CURLOPT_INFILESIZE_LARGE, but it's not defined in PHP | |||
There was a problem hiding this comment.
Out of curiosity: Can we add this constant in php-src/ext-curl? I checked the code there, but I can only find CURLOPT_INFILESIZE, so it may mainly be a copy paste. The problem is, that I did not find the definition for CURLOPT_INIFILESIZE to be 14 to be able to add 115 for the new constant 🤔 Any hints?
There was a problem hiding this comment.
See https://github.com/curl/curl/blob/b13e9066b3dfd65ba8aadc336232ae7832ac687a/include/curl/curl.h#L1541
php-src could add the const for sure, but that won't solve the issue for us since this would be for PHP 8.5 earlier.
There was a problem hiding this comment.
but that won't solve the issue for us since this would be for PHP 8.5 earlier.
that's cristal clear, I know 👍
See: