[Scheduler] Add validation for comma-separated weekdays in PeriodicalTrigger #61143
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…days in PeriodicalTrigger
wazum
force-pushed
the
fix-recurring-message-last-day-60745
branch
from
186da57 to
1122b09
Compare
| @@ -51,6 +51,10 @@ public function __construct( | |||
|
|
|||
| $i = $interval; | |||
| if (\is_string($interval)) { | |||
| if (str_contains($interval, ',')) { | |||
There was a problem hiding this comment.
I feel like this might be too specific.
What about this instead?
--- a/src/Symfony/Component/Scheduler/Trigger/PeriodicalTrigger.php
+++ b/src/Symfony/Component/Scheduler/Trigger/PeriodicalTrigger.php
@@ -117,6 +117,10 @@ class PeriodicalTrigger implements StatefulTriggerInterface
}
}
+ if ($next == $run) {
+ throw new InvalidArgumentException(\sprintf('Invalid interval "%s".', $this->description));
+ }
+
return $next;
}There was a problem hiding this comment.
@nicolas-grekas You are right. I don't think this can be solved at the moment.
I have been working on it for hours now, also with the PHP parser. The underlying problem lies with PHP. Commas is too specific (we would have the same problem with spaces).
I have made a pull request for the documentation, which has already been merged.
Is this a solution that is OK for this problem (via a note in the documentation)?
Developers may continue to define invalid intervals without getting an error.
carsonbot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using
RecurringMessage::every()with comma-separated weekdays like"Monday, Thursday, Saturday", the scheduler silently fails because PHP'sDateInterval::createFromDateString()treats commas as delimiters, not processing the list as intended.Solution
I have done a detailed analysis and searched the PHP documentation. Comma-separated weekday strings are not officially supported by PHP's DateInterval::createFromDateString() method. The PHP manual does not document this format, and testing confirms that commas act as delimiters in the date parsing engine, causing unexpected behavior.
Added validation to detect comma-separated values in PeriodicalTrigger and throw a clear InvalidArgumentException instead of allowing silent failures.
Changes
Alternative: For multiple weekdays, use
RecurringMessage::cron('5 12 * * 1,4,6', $message, 'Europe/Warsaw')instead.Documentation
Update is here: symfony/symfony-docs#21212