Content-Length: 321956 | pFad | http://github.com/symfony/symfony/pull/61188

0D [HttpKernel] Update phpdoc description by alamirault · Pull Request #61188 · symfony/symfony · GitHub
Skip to content

[HttpKernel] Update phpdoc description #61188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Jul 21, 2025

Q A
Branch? 7.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

I used the same wording as getBuildDir method

@OskarStark
Copy link
Contributor

For 7.4 ?

@alamirault alamirault force-pushed the feature/kernel-phpdoc branch from a4d9810 to b5cdeb7 Compare July 22, 2025 06:15
@alamirault alamirault changed the base branch from 8.0 to 7.4 July 22, 2025 06:16
@alamirault
Copy link
Contributor Author

For 7.4 ?

Updated

@@ -113,7 +113,7 @@ public function getStartTime(): float;
/**
* Gets the cache directory.
*
* Since Symfony 5.2, the cache directory should be used for caches that are written at runtime.
* This directory should be used for caches that are written at runtime.
* For caches and artifacts that can be warmed at compile-time and deployed as read-only,
* use the new "build directory" returned by the {@see getBuildDir()} method.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* use the new "build directory" returned by the {@see getBuildDir()} method.
* use the "build directory" returned by the {@see getBuildDir()} method.

Maybe?

@nicolas-grekas nicolas-grekas modified the milestones: 8.0, 7.4 Jul 22, 2025
@nicolas-grekas nicolas-grekas force-pushed the feature/kernel-phpdoc branch from b5cdeb7 to f8719e7 Compare July 22, 2025 08:21
@nicolas-grekas
Copy link
Member

Thank you @alamirault.

@nicolas-grekas nicolas-grekas merged commit c6d8ce0 into symfony:7.4 Jul 22, 2025
11 checks passed
@alamirault alamirault deleted the feature/kernel-phpdoc branch July 22, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/symfony/symfony/pull/61188

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy