[Serializer] Remove require php version in tests #61189
Merged
+0
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santysisi
reviewed
Jul 21, 2025
Comment on lines
-181
to
-183
| /** | ||
| * @requires PHP 8.2 | ||
| */ |
There was a problem hiding this comment.
Could we target the 7.4 branch for this change? Since the PHP minor version used in the 7.4 branch is 8.2, it would make sense to include it there.
OskarStark
approved these changes
Jul 21, 2025
santysisi
reviewed
Jul 21, 2025
Comment on lines
-197
to
-199
| /** | ||
| * @requires PHP 8.4 | ||
| */ |
There was a problem hiding this comment.
Great! In that case, I think it's necessary to restore this comment and delete it only for the 8.0 version 🙂
santysisi
approved these changes
Jul 21, 2025
|
Thank you @alamirault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP has been bump to
>=8.4on branch 8.0 so we can remove these annotations