[DependencyInjection] Update `ResolveClassPass` to check class existence #61215

GaryPEGEOT · 2025-07-23T09:34:39Z

Q	A
Branch?	7.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix #54095
License	MIT

~~Currently doesn't check for incorrect factories, but I'm not sure what would be the best approach~~

src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckServiceClassExistsPassTest.php

src/Symfony/Component/DependencyInjection/Compiler/CheckServiceClassExistsPass.php

nicolas-grekas · 2025-07-24T08:22:28Z

This approach is too broad IMHO. There are cases where the class is eg string for some internal services.

In #54095 (comment), I wrote:

I'm wondering if we shouldn't add the check when the class is not defined for a service (and thus when the id becomes the class).

Can't we patch the existing compiler pass that copies the id to the class when no class is set, and make it throw when id is not a class?

GaryPEGEOT · 2025-07-24T08:39:13Z

Can't we patch the existing compiler pass that copies the id to the class when no class is set, and make it throw when id is not a class?

But then it would not work if you define a manual id and make a typo in the class (although more of a niche case)

GaryPEGEOT · 2025-07-24T08:47:58Z

There are cases where the class is eg string for some internal services.

So we could have something like ['mailer.transport', 'createFromDsn'] at this point? (Not a reference but the service ID as is?

nicolas-grekas · 2025-07-24T08:52:14Z

There are many ways one can mess up with their DI config. Validating everything adds to the compilation time. That's something we always considered outside of the scope of the compilation step.

nicolas-grekas

LGTM, test cases changes look consistent with the updated behavior.

src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/foo.php

src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/fixture_app_services.php

fabpot · 2025-07-25T05:15:03Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveClassPass.php

+                if (!class_exists($id) && !interface_exists($id)) {
+                    $error = $definition instanceof ChildDefinition ?
+                        'has a parent but no class, and its name looks like an FQCN. Either the class is missing or you want to inherit it from the parent service' :
+                        'name looks like an FQCN but the class does not exists';


Suggested change

'name looks like an FQCN but the class does not exists';

'name looks like a FQCN but the class does not exist';

fabpot · 2025-07-25T05:15:18Z

src/Symfony/Component/DependencyInjection/Compiler/ResolveClassPass.php

-                    throw new InvalidArgumentException(\sprintf('Service definition "%s" has a parent but no class, and its name looks like an FQCN. Either the class is missing or you want to inherit it from the parent service. To resolve this ambiguity, please rename this service to a non-FQCN (e.g. using dots), or create the missing class.', $id));
+                if (!class_exists($id) && !interface_exists($id)) {
+                    $error = $definition instanceof ChildDefinition ?
+                        'has a parent but no class, and its name looks like an FQCN. Either the class is missing or you want to inherit it from the parent service' :


Suggested change

'has a parent but no class, and its name looks like an FQCN. Either the class is missing or you want to inherit it from the parent service' :

'has a parent but no class, and its name looks like a FQCN. Either the class is missing or you want to inherit it from the parent service' :

…des/foo.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>

carsonbot added Status: Needs Review DependencyInjection DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature labels Jul 23, 2025

carsonbot added this to the 7.4 milestone Jul 23, 2025

carsonbot changed the title ~~[DX][DI] Add a compiler pass to check class existence.~~ [DependencyInjection] Add a compiler pass to check class existence. Jul 23, 2025

OskarStark changed the title ~~[DependencyInjection] Add a compiler pass to check class existence.~~ [DependencyInjection] Add a compiler pass to check class existence Jul 23, 2025

OskarStark reviewed Jul 23, 2025

View reviewed changes

src/Symfony/Component/DependencyInjection/Tests/Compiler/CheckServiceClassExistsPassTest.php Outdated Show resolved Hide resolved

GaryPEGEOT force-pushed the feat/check-class-pass branch from 740f29a to 65259c9 Compare July 23, 2025 13:19

GaryPEGEOT requested a review from chalasr as a code owner July 23, 2025 13:19

stof reviewed Jul 23, 2025

View reviewed changes

GaryPEGEOT force-pushed the feat/check-class-pass branch from 65259c9 to 321ccff Compare July 24, 2025 08:48

GaryPEGEOT changed the title ~~[DependencyInjection] Add a compiler pass to check class existence~~ [DependencyInjection] Update ResolveClassPass to check class existence Jul 24, 2025

OskarStark changed the title ~~[DependencyInjection] Update ResolveClassPass to check class existence~~ [DependencyInjection] Update ResolveClassPass to check class existence Jul 24, 2025

nicolas-grekas reviewed Jul 24, 2025

View reviewed changes

nicolas-grekas approved these changes Jul 24, 2025

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Jul 24, 2025

fabpot requested changes Jul 25, 2025

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Jul 25, 2025

GaryPEGEOT added 5 commits July 25, 2025 08:53

[DX][DI] Add a compiler pass to check class existence.

2624155

fix: remove void return type

a60af10

feat: check factories as well

e050452

fix: error with reference, add ID in exception message

8460a1b

fix: check factory definition

ee1619e

GaryPEGEOT and others added 9 commits July 25, 2025 08:53

fix: cs

9e227db

fix: update ResolveClassPass to throw when class does not exists

b5d8b19

fix: tests

7e38e69

fix: FrameworkBundle tests

fe5b846

fix: cs

f97fa46

Update src/Symfony/Component/DependencyInjection/Tests/Fixtures/inclu…

bf11378

…des/foo.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>

Update src/Symfony/Component/DependencyInjection/Tests/Fixtures/inclu…

aa1c30e

…des/foo.php Co-authored-by: Nicolas Grekas <nicolas.grekas@gmail.com>

fix: cs

e4158da

fix: typo

349c87c

GaryPEGEOT force-pushed the feat/check-class-pass branch from 9690e1e to 349c87c Compare July 25, 2025 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[DependencyInjection] Update `ResolveClassPass` to check class existence #61215

[DependencyInjection] Update `ResolveClassPass` to check class existence #61215

Uh oh!

GaryPEGEOT commented Jul 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Jul 24, 2025

Uh oh!

GaryPEGEOT commented Jul 24, 2025

Uh oh!

GaryPEGEOT commented Jul 24, 2025

Uh oh!

nicolas-grekas commented Jul 24, 2025

Uh oh!

nicolas-grekas left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabpot Jul 25, 2025

Uh oh!

fabpot Jul 25, 2025

Uh oh!

GaryPEGEOT Jul 25, 2025

Uh oh!

Uh oh!

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

	'name looks like an FQCN but the class does not exists';
	'name looks like a FQCN but the class does not exist';

	'has a parent but no class, and its name looks like an FQCN. Either the class is missing or you want to inherit it from the parent service' :
	'has a parent but no class, and its name looks like a FQCN. Either the class is missing or you want to inherit it from the parent service' :

Uh oh!

[DependencyInjection] Update ResolveClassPass to check class existence #61215

Are you sure you want to change the base?

[DependencyInjection] Update ResolveClassPass to check class existence #61215

Uh oh!

Conversation

GaryPEGEOT commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nicolas-grekas commented Jul 24, 2025

Uh oh!

GaryPEGEOT commented Jul 24, 2025

Uh oh!

GaryPEGEOT commented Jul 24, 2025

Uh oh!

nicolas-grekas commented Jul 24, 2025

Uh oh!

nicolas-grekas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fabpot Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

fabpot Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

GaryPEGEOT Jul 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier! Saves Data!

[DependencyInjection] Update `ResolveClassPass` to check class existence #61215

[DependencyInjection] Update `ResolveClassPass` to check class existence #61215

GaryPEGEOT commented Jul 23, 2025 •

edited

Loading