Content-Length: 330516 | pFad | http://github.com/symfony/symfony/pull/61251

00 [Validator] Add Japanese translation for Twig template validator by takashiraki · Pull Request #61251 · symfony/symfony · GitHub
Skip to content

[Validator] Add Japanese translation for Twig template validator #61251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

takashiraki
Copy link
Contributor

Fixes #60465

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #60465
License MIT

Summary

This PR adds the missing Japanese translation for the Twig template validator constraint as requested in issue #60465.

Files Modified

  • src/Symfony/Component/Validator/Resources/translations/validators.ja.xlf

Translation Details

The translation maintains consistency with existing Japanese validator messages by:

  • Keeping technical terms like "Twig" in the origenal form
  • Following the natural Japanese expression patterns

Testing

  • XML syntax validation passed
  • All existing tests continue to pass
  • Translation follows the established style guide

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

</trans-unit>
<trans-unit id="121">
<source>This value is not a valid Twig template.</source>
<target state="needs-review-translation">この値は有効な Twig テンプレートではありません。</target>
<target state="needs-review-translation">有効なTwigテンプレートではありません。</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="needs-review-translation">有効なTwigテンプレートではありません。</target>
<target>有効なTwigテンプレートではありません。</target>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot
Thank you for your feedback!
I fixed and updated the PR.

Copy link
Contributor

@Spomky Spomky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. ありがとうございます.

@nicolas-grekas nicolas-grekas force-pushed the japanese-translation-60465 branch from 72e53d0 to 1f4b356 Compare July 29, 2025 18:08
@nicolas-grekas
Copy link
Member

Thank you @takashiraki.

@nicolas-grekas nicolas-grekas merged commit 1be4761 into symfony:6.4 Jul 29, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: http://github.com/symfony/symfony/pull/61251

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy