Fix infinite recursion error when vectors are defined incorrectly #27488
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hi, I am the SymPy bot. I'm here to help you write a release notes entry. Please read the guide on how to write release notes. Your release notes are in good order. Here is what the release notes will look like:
This will be added to https://github.com/sympy/sympy/wiki/Release-Notes-for-1.14. Click here to see the pull request description that was parsed. |
Skylion007
reviewed
Jan 19, 2025
sympy/vector/basisdependent.py
Outdated
Comment on lines
275
to
276
| except AttributeError: | ||
| raise ValueError("Wrong way of defining a vector.") |
There was a problem hiding this comment.
This isn't a very descriptive error message?
Suggested change
| except AttributeError: | |
| raise ValueError("Wrong way of defining a vector.") | |
| except AttributeError as exc: | |
| raise ValueError("Wrong way of defining a vector.") from exc |
At least attach the exception cause
There was a problem hiding this comment.
Error message has been improved and the exception cause has been attached now.
Thank you for taking the time to review my code!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to other Issues or PRs
Fixes #27439
Brief description of what is fixed or changed
This PR addresses a bug where incorrectly defining a
Vectorcaused an infinite recursion error.The correct way to define a vector is documented in the [SymPy documentation](https://docs.sympy.org/latest/modules/vector/basics.html#coordinate-systems-and-vectors), as highlighted by @oscarbenjamin in [this comment](#27439 (comment)).
A regression test has been added to ensure this issue does not reoccur.
Other comments
Feedback and constructive criticism are highly appreciated! I am currently learning about SymPy and its codebase by tackling issues I can contribute to.
Release Notes