Fix newExternalWorkflowStub on a interfaces without a WorkflowMethod #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
May 19, 2025
| @@ -20,7 +20,7 @@ public ExternalWorkflowInvocationHandler( | |||
| WorkflowExecution execution, | |||
| WorkflowOutboundCallsInterceptor workflowOutboundCallsInterceptor, | |||
| Functions.Proc1<String> assertReadOnly) { | |||
| this.workflowMetadata = POJOWorkflowInterfaceMetadata.newInstance(workflowInterface); | |||
| this.workflowMetadata = POJOWorkflowInterfaceMetadata.newInstance(workflowInterface, false); | |||
There was a problem hiding this comment.
Got a bit confused on this trailing param reading:
if true, methods of the {@code anInterface} that are
annotated with {@link WorkflowMethod}, {@link QueryMethod}, {@link UpdateMethod}, {@link
UpdateValidatorMethod} or {@link SignalMethod} are processed like {@code current} is a
workflow interface even if it is not annotated with {@link WorkflowInterface} itself.
That'd make me think the default of true should work with non-workflow interfaces. But maybe I'm misunderstanding what was meant there.
Fix a bug causing newExternalWorkflowStub to fail on interfaces without WorkflowMethod
Quinn-With-Two-Ns
force-pushed
the
issue-2180
branch
from
275c323 to
0366dc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug causing newExternalWorkflowStub to fail on interfaces without WorkflowMethod
closes #2180