scene viewport #2229
Draft
scene viewport #2229
+180
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hermet
added
feature
JSUYA
reviewed
Apr 30, 2024
mgrudzinska
force-pushed
the
mira/scene_viewport
branch
3 times, most recently
from
322b83e to
9a25d84
Compare
|
I'll check the regression bugs |
mgrudzinska
force-pushed
the
mira/scene_viewport
branch
from
9a25d84 to
49eae77
Compare
mgrudzinska
force-pushed
the
mira/scene_viewport
branch
from
368ea76 to
c1db549
Compare
|
rebased, no other changes |
JSUYA
reviewed
May 9, 2024
New api can be used to replace clipping with a rectangle. Scenes with viewport set can be still clipped/masked. @issue: thorvg#2172
mgrudzinska
force-pushed
the
mira/scene_viewport
branch
from
c1db549 to
29238f8
Compare
Composition optimized by replacing axis-aligned clipping with viewport.
mgrudzinska
force-pushed
the
mira/scene_viewport
branch
from
29238f8 to
aef2e72
Compare
|
Performance is enhanced by ~3% with Lottie example |
tinyjin
reviewed
May 30, 2024
|
|
||
| bool viewport(int32_t* x, int32_t* y, int32_t* w, int32_t* h) | ||
| { | ||
| if (!vport) return false; |
There was a problem hiding this comment.
Perhaps, It'd be better if we check the case all parameters are nullptr
if (!vport || !(x || y || w || h)) return false;
hermet
force-pushed
the
main
branch
6 times, most recently
from
87ee4f3 to
9b43b93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common: scene viewport api introduced
New api can be used to replace clipping with a rectangle.
Scenes with viewport set can be still clipped/masked.
@issue: #2172
loaders: use viewport in svg/lottie loader
The viewport api is used to replace the rectangular cliping.